Conversation
build.gradle
Outdated
| sourceCompatibility = 1.8 | ||
| targetCompatibility = 1.8 | ||
| version = '0.5.1' | ||
| version = '0.5.2-beta' |
There was a problem hiding this comment.
Following the Semantic Versioning 2.0.0 that we have been using, I recommend this PR to bump CST's version to 0.6.0, as we effectively have a new feature here.
|
|
||
| @Override | ||
| public void proc() { | ||
| outputPlanMO.setI(planning(inputInitialStateMO, inputGoalsMO, inputActionsMO).getI()); |
There was a problem hiding this comment.
Looks good to me, but without a test that can be used also as a spec to this Codelet, it becomes quite hard to understand how all these abstract concepts should be used in practice. What do you think of adding a test to this PR, so anyone would have it as a spec for how to use this new PlanningCodelet?
There was a problem hiding this comment.
André I will implement tests using planning codelet in this PR, but I haven't had time to do that yet.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }); | ||
| } | ||
|
|
||
| public abstract Memory planning(Memory currentState, Memory goals, Memory actions, Memory transitionFunctions, Memory planningRequest); |
There was a problem hiding this comment.
Method planning has 5 arguments (exceeds 4 allowed). Consider refactoring.
| }); | ||
| } | ||
|
|
||
| public abstract Memory planning(Memory initialState, Memory currentState, Memory goals, Memory proceduralMemory, Memory transitionFunctions, Memory planningRequest); |
There was a problem hiding this comment.
Method planning has 6 arguments (exceeds 4 allowed). Consider refactoring.
| }); | ||
| } | ||
|
|
||
| public abstract Memory planning(Memory initialState, Memory observations, Memory goals, Memory proceduralMemory, Memory transitionFunctions, Memory planningRequest); |
There was a problem hiding this comment.
Method planning has 6 arguments (exceeds 4 allowed). Consider refactoring.
|
Code Climate has analyzed commit 2609b29 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 21.4%. View more on Code Climate. |
|
This merge request must be actualized in order to be considered, as there are conflicts with the actual code. |
4 participants
No description provided.